[paludis-dev] [Paludis] #1301: --promote-binaries option

Paludis trac-paludis at exherbo.org
Wed Mar 5 16:44:49 UTC 2014


#1301: --promote-binaries option
-----------------------------+-------------------
    Reporter:  doc.holliday  |      Owner:
        Type:  enhancement   |     Status:  new
    Priority:  Sometime      |  Milestone:
   Component:  clients/cave  |    Version:  1.4.2
  Resolution:                |   Keywords:
  Blocked By:                |   Blocking:
Distribution:  N/A           |
-----------------------------+-------------------

Comment (by ciaranm):

 Looking good. Some little things:

 I think your indenting is off: we use four spaces everywhere.

 {{{ (a_bin || b_bin) && (!a_bin || !b_bin) }}} is very hard to read. Can
 you say {{{ (a_bin != b_bin) }}} ?

 I realise you're probably copy-pasting, but you can use auto rather than
 those long type names for iterators.

 When we have a struct with multiple NamedValue things in it, they're
 always stored in alphabetical order.

 Can you do test cases?

-- 
Ticket URL: <http://paludis.exherbo.org/trac/ticket/1301#comment:14>
Paludis <http://paludis.exherbo.org/>
Paludis, the Other Package Mangler


More information about the paludis-dev mailing list