[paludis-sekrit] Flyweight validateds

Fernando J. Pereda ferdy at gentoo.org
Fri Feb 8 22:48:42 UTC 2008


On Fri, Feb 08, 2008 at 06:03:13PM +0000, Ciaran McCreesh wrote:
> Please try out and benchmark (memory and time, i/o won't change) the
> attached.
> 

--- 8< ---
23:40 < ferdy> http://dev.gentoo.org/~ferdy/tmp/paludis_bench/
23:41 < ferdy> ^^ that has the profiles with and without the patch
23:41 < ferdy> those suffixed with '-paludis' have kernel and library
               times excluded
--- 8< ---

Times and memory usage as follows (the numbers are fairly stable):

unpatched:

  3.10user 0.49system 0:04.46elapsed 80%CPU (0avgtext+0avgdata 0maxresident)k
  0inputs+0outputs (0major+6276minor)pagefaults 0swaps

patched:

  2.87user 0.45system 0:03.77elapsed 88%CPU (0avgtext+0avgdata 0maxresident)k
  0inputs+0outputs (0major+6332minor)pagefaults 0swaps


So allocation seems to be a bit worse and times somehow better. I
expected allocation to be much better.

Also, for --no-threads, it needs the attached :)

- ferdy

-- 
Fernando J. Pereda Garcimartín
20BB BDC3 761A 4781 E6ED  ED0B 0A48 5B0C 60BD 28D4
-------------- next part --------------
diff --git a/paludis/util/rw_lock.cc b/paludis/util/rw_lock.cc
index 593239c..31c762e 100644
--- a/paludis/util/rw_lock.cc
+++ b/paludis/util/rw_lock.cc
@@ -94,7 +94,7 @@ SharedLock::~SharedLock()
 {
 }
 
-ExclusiveLock::ExclusiveLock(RWLock &) :
+ExclusiveLock::ExclusiveLock(RWLock &)
 {
 }
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.exherbo.org/pipermail/paludis-dev/attachments/20080208/de8c6892/attachment.pgp>


More information about the paludis-dev mailing list