[Exherbo-dev] [exherbo-commits] arbor.git -- packages/sys-devel/binutils/ by Ingmar Vanhassel

Ingmar Vanhassel ingmar at exherbo.org
Wed Jul 9 17:55:40 BST 2008


On Wed, Jul 09, 2008 at 07:38:44AM +0200, Markus Rothe wrote:
> git at git.exherbo.org wrote:
> [...]
> > ----
> > diff --git a/packages/sys-devel/binutils/binutils-2.18-r2.exheres-0 b/packages/sys-devel/binutils/binutils-2.18-r2.exheres-0
> > index a62b960..5d3f775 100644
> > --- a/packages/sys-devel/binutils/binutils-2.18-r2.exheres-0
> > +++ b/packages/sys-devel/binutils/binutils-2.18-r2.exheres-0
> > @@ -24,19 +24,20 @@ src_install() {
> >      mkdir -p "${D}/etc/env.d/binutils"
> >  
> >      insinto /etc/env.d/binutils
> > -    cat <<EOF > binutils.env
> > -TARGET="${CHOST}"
> > -VER="${PV}"
> > -LIBPATH="/usr/lib/binutils/${CHOST}-${PV}"
> > -FAKE_TARGETS="${CHOST}"
> > -EOF
> > +    cat <<-"    EOF" > binutils.env
> > +    TARGET="${CHOST}"
> > +    VER="${PV}"
> > +    LIBPATH="/usr/lib/binutils/${CHOST}-${PV}"
> > +    FAKE_TARGETS="${CHOST}"
> > +    EOF
> [...]
> 
> Doesn't this create blanks at each line of binutils.env?
> 
> IMO the old version was better, because the file in the filesystem looks
> cleaner.
> 
> Regards,
> 
> -markus

It does, and that's ugly.

I've reverted the patch in ec26353, thanks!




More information about the Exherbo-dev mailing list